Skip to content

OCPEDGE-2196: feat: add support for TNF agent based install #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPEDGE-2196: feat: add support for TNF agent based install #1798

wants to merge 1 commit into from
+46 −6

Conversation

eggfoobar
Copy link
Contributor

No description provided.

This was referenced Sep 22, 2025
Open
Open
@eggfoobar eggfoobar changed the title feat: add support for TNF agent based install OCPEDGE-2196: feat: add support for TNF agent based install Sep 24, 2025
@eggfoobar
Copy link
Contributor Author

/retest-required

andfasano
andfasano reviewed Sep 29, 2025
View reviewed changes
@eggfoobar eggfoobar force-pushed the add-agent-based-tnf-support branch from 9f88a96 to 3fd5bcd Compare September 30, 2025 03:14
@eggfoobar
Copy link
Contributor Author

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor Author

/retest-required

andfasano
andfasano reviewed Oct 1, 2025
View reviewed changes
@eggfoobar eggfoobar force-pushed the add-agent-based-tnf-support branch 2 times, most recently from 73cd1c3 to 1a138da Compare October 2, 2025 04:59
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

/retest

@eggfoobar eggfoobar force-pushed the add-agent-based-tnf-support branch from 1a138da to f9d5f98 Compare October 6, 2025 03:55
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar eggfoobar force-pushed the add-agent-based-tnf-support branch 3 times, most recently from a4301f5 to 506935e Compare October 7, 2025 17:08
@eggfoobar
Copy link
Contributor Author

/retest

@andfasano
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
jaypoulz
jaypoulz reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@jaypoulz jaypoulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we LGTM, can you review the comments I've provided?

@eggfoobar
feat: add support for TNF agent based install
8460bc9 
added ENABLE_TWO_NODE_FENCING internal variable to help identify fencing
for templating.
added fencing block in jinja baremetal install config
added BMC driver validation for two node fencing to make sure only
redfish is used

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar force-pushed the add-agent-based-tnf-support branch from 506935e to 8460bc9 Compare October 13, 2025 20:18
@eggfoobar
Copy link
Contributor Author

/retest

2 similar comments
@eggfoobar
Copy link
Contributor Author

/retest

@elfosardo
Copy link
Member

/retest

@eggfoobar
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 15, 2025

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm 8460bc9 link true /test e2e-metal-ipi-bm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

2 more reviewers

@jaypoulz jaypoulz jaypoulz left review comments

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eggfoobar @andfasano @elfosardo @jaypoulz